- last update
over 1 year ago 81 pass, 2 fail - last update
over 1 year ago 85 pass - last update
over 1 year ago 85 pass - 🇳🇱Netherlands megachriz
I think that improvements can be made to the provided process plugins:
- A typo in EntityGenerateForm: 'ke2:value2'
- EntityLookupForm could let the user choose entity type and bundle from a list - and I think autoset bundle key this way?
- For some string translations double quotes are used where single quotes could be used as well.
- In some cases the field descriptions are nearly the same as the labels, like in EntityLookupForm:
$form['bundle_key'] = [ '#type' => 'textfield', '#title' => $this->t('Entity type bundle key'), '#description' => $this->t("The entity type bundle key."), '#default_value' => $this->configuration['bundle_key'], ];
In this case either omit the description or provide a more useful description.
- Maybe it would be good idea to add functional tests for each process plugin that we add a form plugin for.