Add migrate process form plugins

Created on 22 January 2021, almost 4 years ago
Updated 7 June 2023, over 1 year ago

Problem/Motivation

Add migrate process form plugins for:

  • array_build
  • callback
  • entity_generate
  • entity_lookup
  • migration_lookup
  • skip_on_empty
  • skip_on_value

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Needs work

Version

1.0

Component

Code

Created by

🇨🇳China ipumpkin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    81 pass, 2 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    85 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    85 pass
  • 🇳🇱Netherlands megachriz

    I think that improvements can be made to the provided process plugins:

    1. A typo in EntityGenerateForm: 'ke2:value2'
    2. EntityLookupForm could let the user choose entity type and bundle from a list - and I think autoset bundle key this way?
    3. For some string translations double quotes are used where single quotes could be used as well.
    4. In some cases the field descriptions are nearly the same as the labels, like in EntityLookupForm:
      $form['bundle_key'] = [
        '#type' => 'textfield',
        '#title' => $this->t('Entity type bundle key'),
        '#description' => $this->t("The entity type bundle key."),
        '#default_value' => $this->configuration['bundle_key'],
      ];
      

      In this case either omit the description or provide a more useful description.

    5. Maybe it would be good idea to add functional tests for each process plugin that we add a form plugin for.
Production build 0.71.5 2024