Event view 'No results' has obsoleted markup.

Created on 19 January 2021, over 3 years ago

Updated 13 February 2023, over 1 year ago

Problem/Motivation

The 'no results' entry of the Sector Events (sector_event) view has obsoleted markup. Additionally, the 'note' library isn't been included and the class on the view has-filters-with-responsive-layout is redundant.

<div class="prose has-margin-top-double">
<div class="note note--primary">
<p class="lead">Sorry. We can't find what you are looking for. You can <a href="/events">reset the filters</a> and try again, or use our <a href="/search">site-wide search</a>.</p>
</div>
</div>

Steps to reproduce

See 'No results behaviour' - /admin/structure/views/view/sector_event/edit/page_1

Proposed resolution

Replace has-margin-top-double with mt-4 and investigate if 'note' is required going forward.

📌 Task

Status

Fixed

Version

3.0

Component

Code

Created by

🇳🇿New Zealand Chroid

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
System Message

dieuwe → committed 52415d57 on 3.0.x authored by mohit.bansal623 →
Issue #3193660 by mohit.bansal623, Chroid: Event view 'No results' has...
Status changed to Fixed over 1 year ago4:19am 13 February 2023
Comment over 1 year ago →
🇳🇿New Zealand dieuwe Auckland, NZ
I know it's been a long time - but years later and the patch still applies. The 'note' classes are correct and still useful for the Sector theme.
Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024