Recursive rendering limit prevents more than two instances of an entity being rendered non-recursively.

Created on 13 January 2021, about 4 years ago
Updated 14 January 2025, 3 months ago

Problem/Motivation

The logic intended to prevent recursive rendering prevents all renders of a given node past the second, even if it's not recursive. This prevents use cases such as featuring fields within different view modes on a homepage (for example).

Steps to reproduce

Place 3 separate entity browser blocks that reference the same entity on a page. The 3rd one will not render.

Proposed resolution

Instead of counting times an entity has been seen, let's check if the combination of entity type, entity id, and view mode has been seen. That way we can have an arbitrary number of instances of the same entity with different view modes, and still prevent loops since the second time an entity is viewed with the same view mode, it will not be rendered.

Remaining tasks

Review!

User interface changes

N/A

API changes

Added a new protected function to check if the entity has been rendered with the view mode.

Data model changes

N/A

πŸ› Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States xaqrox Washington, D.C.

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024