- 🇳🇱Netherlands marcom2021
Why isn't this fixed yet? This module is useless as it breaks the intergration after 1 hour.
- 🇧🇪Belgium svendecabooter Gent
I don't have an active project with Teamleader integration anymore, so currently no time to work on a fix.
If someone creates a MR and proposes a fix, I'd be happy to review & commit. - 🇧🇪Belgium j0sbeir
This should in no way be merged but attached patch works around this by manually refreshing the access token using the mode service.
- Merge request !2Issue #3190343: Rewrite module to make use of better maintained TL library (janhenkes/teamleader-php-sdk) → (Merged) created by j0sbeir
- Assigned to j0sbeir
- Status changed to Needs review
9 months ago 8:20am 31 March 2024 - 🇧🇪Belgium j0sbeir
I think this now ready for merge and release as a 4.x major release.
Can someone take some time to review ?
- 🇧🇪Belgium svendecabooter Gent
@j0sbeir
Thanks for the effort to update the module against the janhenkes library.
I have done some additional commits for cleanup and some issues I encountered while testing. Let me know if you don't agree with any of the changes, so we can discuss that further.For now I will merge this into a new 4.0.x branch and create a first alpha release.
- Issue was unassigned.
- Status changed to Fixed
9 months ago 11:30am 4 April 2024 -
svendecabooter →
committed 7c65193e on 4.0.x authored by
j0sbeir →
Issue #3190343 by j0sbeir, svendecabooter: Rewrite module with better...
-
svendecabooter →
committed 7c65193e on 4.0.x authored by
j0sbeir →
- 🇧🇪Belgium j0sbeir
Thanks! phpcs was spitting out a small notice about the @mixin phpdoc in the newly added interface. Fixed it in my branch, but probably not worth a MR.
Automatically closed - issue fixed for 2 weeks with no activity.