Fix PHP 8 test fails

Created on 27 December 2020, over 3 years ago
Updated 29 May 2023, about 1 year ago

Problem/Motivation

Add module compatibility for PHP 8 on Drupal 9.1

πŸ“Œ Task
Status

Closed: outdated

Version

1.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany Universaldenker

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    A first step would be to update the testing configuration. Tests are being run on PHP 7.3. The only PHP 8 test is on Drupal 10.1.

  • Status changed to Closed: outdated about 1 year ago
  • πŸ‡¨πŸ‡­Switzerland Berdir Switzerland

    This is an old issue, while there seem to be some D10.1 test issues atm, PHP8 test fails were fixed as part of D10 compatibility.

  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    The testing config is still out of date and tests are failing on the PHP 8 testing configurations that do exist.

  • πŸ‡¨πŸ‡­Switzerland Berdir Switzerland

    The test configurations deliberately test on the lowest supported version on D9, and D10.0 is passing except a single hal related issue on PHP8, the other 10.1 fails are new, so they are not PHP 8 related. You're welcome to create a new issue for the D10 issues, I'll get to it at some point too.

  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    It would be helpful to see Drupal 9 tests on more recent PHP. That allows people to see whether the module is likely to work if they are running more recent PHP.

Production build 0.69.0 2024