Because GlobalDrupalSniff only checks the base class extended by the given class, it fails to detect a variety of instances where global Drupal calls are "bad." This might be a case where the base class simply isn't listed, such as any generic plugin that would extend PluginBase, or one that extends a class that extends one of the listed $baseClasses, or simply a generic service implementation that does not extend any other classes.
Run DrupalPractice against any class that would go into /src/ that does not explicitly extend one of the classes listed in $baseClasses.
Replace the $baseClasses check with one that simply checks if this class's file resides in /src/, and add additional help text to the $warning to suggest that Plugins should implement ContainerFactoryPluginInterface.
Needs review
3.0
Coder Sniffer
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Added https://github.com/pfrenssen/coder/issues/238, please review.
Thanks, reviewed https://github.com/pfrenssen/coder/pull/239
Approach makes sense, please add test coverage.