- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I suspect this is not a bug since we always release locks at the end of a request with a shutdown function.
See https://git.drupalcode.org/project/drupal/blob/e0b4b7ef6e6997d9446e60486...
FileUploadResource uses a lock to prevent duplicate file name uploads. The lock is never released when an exception is thrown during file validation.
1) Send a file that fails validation, for example because of file size.
2) Send the same file name with correct file size.
3) You get a 503 locked exception although the upload should work.
Always release the lock with a finally {} block in FileUploadResource. The same thing was done in GraphQL module in https://github.com/drupal-graphql/graphql/pull/1118
2) How could we test this?
Postponed: needs info
11.0 🔥
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I suspect this is not a bug since we always release locks at the end of a request with a shutdown function.
See https://git.drupalcode.org/project/drupal/blob/e0b4b7ef6e6997d9446e60486...