FileUploadResource does not release lock on validation errors

Created on 26 November 2020, about 4 years ago

Updated 10 September 2024, 5 months ago

Problem/Motivation

FileUploadResource uses a lock to prevent duplicate file name uploads. The lock is never released when an exception is thrown during file validation.

Steps to reproduce

1) Send a file that fails validation, for example because of file size.
2) Send the same file name with correct file size.
3) You get a 503 locked exception although the upload should work.

Proposed resolution

Always release the lock with a finally {} block in FileUploadResource. The same thing was done in GraphQL module in https://github.com/drupal-graphql/graphql/pull/1118

Remaining tasks

2) How could we test this?

🐛 Bug report

Status

Closed: outdated

Version

11.0 🔥

Component

File module →

Last updated 9 days ago

Maintained by
🇦🇺Australia @kim.pepper

Created by

🇦🇹Austria klausi 🇦🇹 Vienna

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Bug Smash Initiative

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
I suspect this is not a bug since we always release locks at the end of a request with a shutdown function.

See https://git.drupalcode.org/project/drupal/blob/e0b4b7ef6e6997d9446e60486...
Status changed to Closed: outdated 5 months ago2:57am 10 September 2024
Comment 5 months ago →
🇦🇺Australia kim.pepper 🏄‍♂️🇦🇺Sydney, Australia
Since this issue was created, we moved implementation to the common FileUploadHandler which now handles locking in a finally block.
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...

I think we can close this issue. Please re-open if you think otherwise.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024