- 🇨🇭Switzerland Berdir Switzerland
This module now has tests on merge requests ( doesn't show up here), and they are failing, which is expected based on what was discussed in the related github issue.
- 🇺🇸United States lcatlett
This patch has been required for Pantheon customers hitting maxmemory limit and is critical to evicting keys as expected using LRU
- First commit to issue fork.
- 🇺🇸United States Ec1ipsis
I can't tell whether the automated test needs to change or if the behavior itself has a bug. I've merged in the most recent release to the 8.1 branch, and the error that I'm seeing from PHPUnit is:
1) Drupal\Tests\redis\Kernel\RedisCacheTest::testSetGet Failed asserting that false is of type "object". /builds/issue/redis-3179757/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122I believe that the automated test itself needs to be updated, but I'm not certain. Anyone have a firm answer on that?
- 🇨🇭Switzerland Berdir Switzerland
See the duplicate issue #2877893: Cache Expiration doesn't follow Drupal conventions → where I've explained this about 7 years ago :)
The test is from core. Core expects that the API allows to return expired cache items if you ask for that. Setting a TTL in redis is incompatible with the expectation that core has for a cache backend implementation.
The only way to get tests to pass is to make this behavior configurable. Either a boolean enable/disable, or an idea I just had, is that we add a ttl offset setting. So that can be set to e.g. 300, then any ttl we receive is extended by 300s, which means that for this timeframe, we can still return expired items, allowing certain use cases like returning expired items while one process recalculates it. Then we just need to configure that specific test to have enough ttl offset for the tests to still work.