- 🇦🇺Australia klonos 90% Melbourne, Australia - 10% Larissa, Greece
Updating issue summary with some details and slightly reordering steps to what makes sense.
- Status changed to Needs review
over 1 year ago 5:07pm 9 February 2023 - 🇧🇷Brazil murilohp
Thanks for IS update @klonos, with that information I was able to create a test and replicate the bug. Here's a new patch, and a test-only patch.
The last submitted patch, 48: 3179599-48-test-only.patch, failed testing. View results →
- Status changed to Needs work
over 1 year ago 2:35pm 10 February 2023 - 🇬🇧United Kingdom jonathanshaw Stroud, UK
Nice work @murilohp
+++ b/core/modules/path/tests/src/Functional/PathLanguageTest.php @@ -212,4 +212,32 @@ public function testAliasTranslation() { + $this->assertSession()->pageTextContains('Basic page ' . $edit['title[0][value]'] . ' has been created.');
I don't really like this as a way of verifying the outcome here. I'd prefer to see something that proves more explicitly that we really have 2 nodes with the correct different paths.
Otherwise RTBC.
- Status changed to Needs review
over 1 year ago 3:06am 3 March 2023 - 🇧🇷Brazil murilohp
Hey! Thanks for the review @jonathanshaw! I've updated the test, now, the test will test,validate the page and also asserts the path alias.
@Nikhil_110, thanks for the patch, but I didn't get what you've done, you basically changed an unrelated test, so this new patch is based on #48.
- Status changed to Needs work
over 1 year ago 7:19am 3 March 2023 - 🇬🇧United Kingdom joachim
+++ b/core/modules/path/src/Plugin/Field/FieldWidget/PathWidget.php @@ -83,7 +83,12 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen + $other_alias = \Drupal::service('path_alias.manager')->getPathByAlias($alias, $form_values['langcode'][0]['value']);
This could do with a comment to explain what it's doing.
Currently it looks like it's part of the 'Trim...' code.