Not handling error exception in a better manner in case of same code entered.I get a PDOException on the second entry of the same code.
If I enter the same code twice I get a PDOException on the second entry. There should be a more graceful error message than this:
PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'temp8' for key 'code': INSERT INTO {regcode} (created, begins, expires, code, is_active, maxuses) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5); Array ( [:db_insert_placeholder_0] => 1394661983 [:db_insert_placeholder_1] => [:db_insert_placeholder_2] => [:db_insert_placeholder_3] => temp8 [:db_insert_placeholder_4] => 1 [:db_insert_placeholder_5] => 1 ) in regcode_save() (line 494 of /....../sites/all/modules/regcode/regcode.module).
Needs review
1.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
It looks like I inadvertently included this patch in 📌 Replace module procedural functions with a service Needs review for the 2.0.x branch, but this should also be put into 8.x-1.x and a test added to both branches.
The test needs to:
1) Demonstrate the error without the patch in place.
2) Demonstrate that the error goes away with the patch in place.