- Issue created by @tr
- Merge request !8Issue #3471716 by TR: Replace module procedural functions with a service β (Open) created by tr
- Status changed to Needs review
4 months ago 6:35am 3 September 2024 - πΊπΈUnited States tr Cascadia
I spent an awfully long time cleaning up typing errors and phpcs errors and cspell notices and phpstan errors, but most of those were inherited from the old procedural function definitions. And, since there are no tests for this module still, the only thing we have to go on is these code quality checks.
There are a few phpcs notices left - these are missing parameter descriptions which were also missing from the procedural functions in the .module. While I added a whole lot of parameter descriptions, there were a few I wasn't sure about without doing a lot more research, so I left those blank. They can be cleaned up in another issue.
- πΊπΈUnited States tr Cascadia
Created a new MR because it's easy to deal with the changes from π [9.4] All hook invocation delegated to Module Handler service Fixed in a new branch rather than deal with all the merge conflicts in the old branch.
- Merge request !12Issue #3471716 by TR: Replace module procedural functions with a service β (Merged) created by tr
- Status changed to Fixed
3 months ago 5:34pm 6 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.