- 🇩🇪Germany Anybody Porta Westfalica
@jacobbell84 great work! Patch looks very promising. I think the last step would be to have a test to ensure it works as expected. And perhaps use a MR instead?
Currently if you use a remote file stream module, like s3fs, the document redirects will fail with the following error:
Redirects to external URLs are not allowed by default, use \Drupal\Core\Routing\TrustedRedirectResponse for it
Refactor the module slightly to use the CacheableRedirectResponse if the stream is flagged as LOCAL (or one of its variants), otherwise use the TrustedRedirectResponse. This seems to work fine with both local streams and remote streams.
Needs review
1.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
@jacobbell84 great work! Patch looks very promising. I think the last step would be to have a test to ensure it works as expected. And perhaps use a MR instead?