You may have to rebuild permissions for your changes to take effect.

Created on 21 October 2020, about 4 years ago
Updated 20 June 2024, 5 months ago

Problem/Motivation

Getting the message about rebuild after saving changes to access control for a single node. Is this ever true? The ContentAccessPageForm displays this message for all saves. Are there are any cases where a single node access update requires a full rebuild? Maybe this message is in the wrong file?

Steps to reproduce

Enable "per-node" access control for a given content type. Edit a node of that type, use the Access Control tab to change the settings from the default for the content type, and save the node access change. Receive the message "Your changes have been saved. You may have to rebuild permisions for your changes to take effect." (note typo in spelling of permissions)

Proposed resolution

Remove this message if it is indeed spurious. Or move it to the ContentAccessAdminSettingsForm file.

🌱 Plan
Status

Postponed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States john.oltman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡΄Norway gisle Norway

    This should go into the the most recent branch.

  • πŸ‡ΊπŸ‡ΈUnited States drupgirl

    This message is quite confusing for end users. It's a "success" message that reads/acts like a failure. Imo the simplest solution is to send this message to the system log and remove the message from the user.

  • πŸ‡³πŸ‡΄Norway gisle Norway

    It has been a lot of water under the river since I wrote comment #5 (in 2020), and it turns out that not rebuilding permissions when it is required may in certain situations constitute a security vulnerability. See the related issue πŸ› Does not react to role changes Fixed for background.

    It would be much better if somebody could find some time to drill down into this, identify the situations were rebuilding permissions are required, and identify those when it is not. However, until somebody does this (see suggestions for how to proceed in comment #5), these messages stay in the user interface.

  • πŸ‡¨πŸ‡¦Canada alienzed

    You'd think that, instead of displaying this message to end users who cannot do anything about it, that a Rebuild Permissions would just be triggered, period. No?

  • πŸ‡³πŸ‡΄Norway gisle Norway

    Yes. An MR/patch that does trigger rebuild permissions in the right context shall be welcome.

  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States loze Los Angeles

    loze β†’ changed the visibility of the branch 3178212-check-rebuild-access to hidden.

Production build 0.71.5 2024