- 🇪🇸Spain Peacog
This issue is related to 🐛 Webp derivatives not refreshed when files stored in sub-directory Needs review . When that other issue is merged, the code in the new getWebpCopy() method provided by this patch will need to be updated to
$destination = $this->getWebpDestination($uri, '@directory/@filename.webp');
- 🇨🇦Canada mandclu
Can someone provide steps to reproduce? Does this only occur when using Webp with private files?
I tried adding debugging code to the generation method, and it fires when the image is first uploaded, but not when the image is requested again.
- 🇪🇸Spain Peacog
I'm not able to reproduce the problem in 🐛 Webp derivatives not refreshed when files stored in sub-directory Needs review any more. Maybe there was a particular combination of versions and patches I was using that caused it. I've struck through my comment above so it doesn't cause confusion
- First commit to issue fork.
- Merge request !39Draft: Issue #3177103: Do not regenerate the webp file each time it is requested - patch #2 applied → (Open) created by abhaisasidharan
- 🇮🇳India abhaisasidharan
https://git.drupalcode.org/project/webp/-/merge_requests/39, rebases with 8.x-1.x branch so that the .diff patch can be used with rc2 version module.
- Status changed to Postponed: needs info
6 months ago 4:19am 12 May 2024 - 🇧🇷Brazil edmargomes
I have this problem here cfr.org.
To reproduce:
Set the quality to 85% in the webp module
Create an image style with Convert WEBP
Access the image several times and keep downloading, don't forget to use an anti cache in the url ?cache=93893984I updated the patch to RC2
- Status changed to Needs review
4 months ago 4:22pm 12 July 2024 - 🇨🇦Canada bonfil1 British Columbia
I tested #32 with the following:
* Use a clean D10 environment with drupal core 10.3 / PHP 8.4
* install enabled the webp module with the same settings as other envs and quality set to 85
* create an article and uploaded a new image with 200kb of size
* reload the node and the image by certain amount of times, as i found even since the first time the file compression starts to happen
* download that image coming from drupal and compress as webp
* notice the difference in size, each time the difference is minimal even by bytes but still happens
* import/install #32 patch and repeat above
* images were not compressed more than onceconfirming #32 works.