Drupal 9 core_version_requirement

Created on 7 October 2020, about 4 years ago
Updated 25 November 2023, about 1 year ago

There is a patch here:
https://www.drupal.org/project/videojs/issues/3149257 πŸ“Œ Automated Drupal 9 compatibility fixes Closed: won't fix

That includes D9 deprecation fixes, plus the `core_version_requirement` change for D9 support.
This patch applies cleanly and works great, in typical scenarios.

There is also a very similar patch here:
https://www.drupal.org/project/videojs/issues/3117973 πŸ“Œ Drupal 9 Compatibility Fixed
This patch actually doesn't apply for me.

In #3149257, I mentioned that, however, I was having issues applying the patch because I was also already using this patch, that adds poster image support:
https://www.drupal.org/node/2782677 β†’

And a change in that patch actually removes some lines that the D9 patches are fixing deprecations on, so that is causing an issue with the patches applying together.

My thought was that in this atypical scenario (there may be others using this patch too), that it would be more manageable to have the D9 deprecations patch in one issue and the `core_version_requirement` change in another issue. So, that is the reason for this seemingly duplicate issue.

The task here would be to add a patch that adds the `core_version_requirement` line to the module's info.yml file, per:
https://www.drupal.org/node/3070687 β†’

This would allow projects, such as mine, to selectively only using the `core_version_requirement` patch and NOT the D9 fix patch, since the poster image patch removes the lines that it is affecting anyways.

πŸ“Œ Task
Status

Closed: won't fix

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States joshua.boltz

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024