Allow new_content JS event listeners access to the actual new content

Is this still an issue with 2.0.x? If yes, please update the version and set the status active again with clear steps or (best) with a test showing what's broken.

2.0.x is the active development branch.

If nobody replies, we should assume this is fixed and close this issue outdated.

Thanks!

Hi, yes this is still an issue on version 2.0 without the patch. To reproduce:

Create a view with views infinite scroll but without the autoscroll behavior. Using the keyboard, focus the "Load more" button and hit enter.

Desired behavior: More rows load and focus jumps to the first focusable item in the first new row.

Actual behavior: More rows load and focus stays on the "Load more" button.

Does anyone know why clone() was used before?

-      .trigger('views_infinite_scroll.new_content', $newRows.clone())
+      .trigger('views_infinite_scroll.new_content', $newRows)

Doesn't really make sense to me...

Could someone look up the issue via GitLab blame and see if there was a reason given?

@anybody

Could someone look up the issue via GitLab blame and see if there was a reason given?

I don't see a reason. Looks like it was added in commit 95af31da for #3068579: Add a jQuery event when new content is loaded → .

Since the second argument of .trigger() is used to pass data to event handlers, the .clone() might have been to prevent mutation of the $newRows object by buggy event handlers.

Thanks, someone should please create a MR from the patches.

I'll do it.