Missing media in previous node revisions

Created on 17 September 2020, over 4 years ago
Updated 5 September 2023, over 1 year ago

Problem/Motivation

If i used a media in previous node revisions, everybody (exclude administrators and owners) will missing permission to access this media.

return AccessResult::forbidden('Access to this media asset is restricted to administrators and owners.');

But if i has permission to view all revisions, and see this node revision, the media will missing.

I think we should check all parent revisions' access.

Steps to reproduce

- Given I am an administrator
- Create a Draft node contain a media file by CKEditor Embed
- Then remove this media, and publish this node.
- Given I am a user that have view all revisions permission (no administrator)
- Then goto node revisions' list, see the draft version
- Missing media.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

🇨🇳China Oscaner

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024