- First commit to issue fork.
- @kurttrowbridge opened merge request.
- Status changed to Needs review
8 months ago 3:38am 2 November 2023 - 🇺🇸United States KurtTrowbridge
Hi! I ran into this today too on a site running Drupal 9.5.11. I was able to get the newly added handler to open its configuration form after making some adjustments, matching a couple other Webform handlers I referenced. After that, I hit some issues related to the Comparison Operator field due to how the title was formatted, so I provided an adjustment that moves the additional information for that field into a description. Lastly, I had an issue saving the configuration form because it tried to validate the comparison operator based on the value of
$values['compare']['operator'], when the variable appears like it should be$values['operator']–only theleftandrightvalues are nested under$values['compare'].Hopefully that all makes sense. I confirmed that the comparison was working for me following those adjustments, and confirmed that the file meets Drupal's code standards (one other adjustment needed for that was to put the
usestatements in alphabetical order). Everything I've mentioned is in the provided merge request, but I'd definitely appreciate a review—dependency injection is not my strong suit, and a couple of the fixes were a little unexpected to me.Thanks!