Ability to configure absolute/relative urls

Created on 11 September 2020, over 4 years ago
Updated 14 August 2024, 5 months ago

Awesome module to begin with and when dealing with rest the export field with the url meta was perfect for our taxonomy api. However forcing them to be absolute urls was a huge issue for us as when you decouple you need relative urls.

I created a very small patch to remove the absolute option, that said I think a checkbox to switch between would be best.

✨ Feature request
Status

Fixed

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States glynster

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡­Switzerland cburschka

    Tricky, but not as much as I feared.

    The entity_reference URL belongs to the "extra" values which are not technically fields, and which are emitted depending on checkboxes in the settings form. It would be feasible to create additional settings for some of these values that are conditional on the checkbox being checked.

    (Beside the URL, it might be useful to do this with the "Author" field, which is technically itself an entity_reference field but which is impossible to customize via the view-mode. Currently it looks like the "Author" checkbox in the settings doesn't actually do anything, and the "uid" field is always emitted as an HTML string.)

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    I am moving support to version 3, can you please confirm if this issue still exists in version 3.
    If it does still exist please change the version dropdown to 3.0.x and set the status to Needs Work.

    I suspect this issue has not been fixed so we can look at it there if you confirm.

    Thank you!

  • leymannx Berlin

    Configurable would be nice. Alternatively we could just extend the path formatter.

  • Status changed to Needs review 5 months ago
  • leymannx Berlin

    Strange, when I add the settings form it takes effect as expected BUT the views field config suddenly gets output twice. πŸ€”

    Maybe I did something wrong or this is part of what @cburschka points out to in comment #4.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Thank you leymannx, please post that as a merge request and I would be happy to review it for you and merge it in once it's complete.

  • Status changed to Needs work 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
  • Assigned to nicxvan
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    Actually I can move it to an MR for now, if you figure out why it's duplicating that would be great.

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    I moved the schema to the existing config/schema

  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
  • Merge request !21Absolute vs relative urls β†’ (Merged) created by nicxvan
  • Issue was unassigned.
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan

    With the changes I made I don't see the duplicate summary, do you see the duplicate still with the MR?
    (I moved the schema and I added $summary = parent::settingsSummary();)

    If not I'll merge this in once you confirm.

  • Status changed to Needs review 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
  • leymannx Berlin

    Ahhh yeah, could be the duplicate schema file caused that glitch. Currently AFK for 1h, will check when I'm back. Thank you @nicxvan πŸ€—

  • leymannx Berlin

    For me it was not a duplicate summary, for me it was the whole settings form being duplicated.

    As soon as I added the parent calls like you did, it works. This I can confirm now.

    Leaving on needs review for you to review again.

  • Pipeline finished with Failed
    5 months ago
    Total: 153s
    #238721
  • leymannx Berlin

    I think doing the parent calls in all settings related methods is a standard thing to do in all field formatters I can see so far.

  • Status changed to Fixed 5 months ago
  • πŸ‡ΊπŸ‡ΈUnited States nicxvan
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024