Contrib.social

Move .form-inline .form-item-separator rules from inline-form css to field UI css

Open on Drupal.org →
Created on 8 September 2020, over 4 years ago
Updated 18 October 2024, 2 months ago

Problem/Motivation

In the several instances of inline-form.css, there are styles with this selector
.form--inline .form-item-separator
This selector is not a utility class, but specific to a form element added in \Drupal\field_ui\Form\FieldStorageAddForm

 $form['add']['separator'] = [
        '#type' => 'item',
        '#markup' => $this->t('or'),
      ];

These styles are field ui specific, so it would be more appropriate in field UI css, even if the .form--inline class is present.

Steps to reproduce

Proposed resolution

Remaining tasks

Move this style in all applicable CSS instances. Claro may not need this if ✨ Add support for the inline variation of form elements Needs work has landed.

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

11.0 🔥

Component

CSS

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Merge request !98723169719: Move .form-inline .form-item-separator rules from inline-form css to field UI css. → (Open) created by Unnamed author
  • Pipeline finished with Success
    2 months ago
    Total: 367s
    #313701
  • Comment 2 months ago →
    🇮🇳India nayana_mvr

    I have re-rolled the patch for Drupal 11.x and raised MR. Please review.
    There are two more CSS instance other than Claro where this update may require i.e.,core/profiles/demo_umami/themes/umami/css/classy/components/inline-form.csscore/themes/starterkit_theme/css/components/inline-form.css. But I couldn't find any separate file for field-ui in those 2 themes. So didn't make any changes there.

  • Comment about 2 months ago →
    🇺🇸United States smustgrave

    For me I'm -1 for this change. Duplicating the code, as mentioned, into 2 spaces and breaking form-inline stuff up. So tagging for framework manager.

  • Comment about 1 month ago →
    🇺🇸United States bnjmnm Ann Arbor, MI

    When I was working on ✨ Add support for the inline variation of form elements Needs work over four years ago, I created this ussue as this was one of several things that might improve the feasibility of that issue landing. TBH I think it's very unlikely that issue will ever land and getting something like this in will not increase its changes. The changes are too far reaching and disruptive - even if core worked solidly there would be countless problems with the contrib.

    I'm just going to close this and someone can reopen if there's a really compelling reason beyond nudging forward a Claro issue that is unlikely to ever be completed.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024