CKEditor drupallink and regular link conflict

Created on 19 August 2020, over 4 years ago
Updated 10 November 2023, about 1 year ago

Problem/Motivation

If you have the ckeditor configured with drupallink and the regular link plugin a doubleclick on a link in the ckeditor will result in opening two modal dialogues.

We provide a possible solution and a patch for this issue. Can please somebody check if this occurs globally for everyone and check our provided solution?

Steps to reproduce

  1. Configure ckeditor to use drupallink and the regular link plugin.
  2. Add a link to any node where the ckeditor is used and both plugins are configured.
  3. Two modal dialogues will open instead of one.

Proposed resolution

Only open one of the modal dialogues according to attributes attached to a-element. Use the drupallink if we have a data-entity-type attribute for the a-element. If there is none use the regular link modal.

Remaining tasks

Review by community and check if this problem also occurs for others, applying patch to core.

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

🐛 Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

🇩🇪Germany picturemaxx

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024