Drush 10/11 support

Created on 6 August 2020, over 4 years ago
Updated 25 January 2023, almost 2 years ago

Problem/Motivation

In Drush 10 the way on writing command is changed completed. It no longer support hooks (hook_drush_command), hence need to rewrite drush support.

Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

🇮🇳India Sharique

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇬🇧United Kingdom james.williams

    I've got this working runs saved by tideways_xhprof, using the latest patch here, but I also had to make a couple more changes:

    1) The source=Drush query string parameter doesn't 'stick' around various links in the UI (e.g. when sorting from table headers, or clicking the 'show all' link above the table). So I just temporarily hacked \Drupal\xhprof\Profiler::getNamespace() beyond what the patch did, to just always return 'Drush'.

    2) I couldn't see how to set the output directory for tideways_xhprof; it always wrote into /tmp for me. The xhprof.output_dir PHP seems to be ignored (which makes sense, given it's a different extension), and it doesn't seem to use what's returned by sys_get_temp_dir() either. So I had to add arguments: ['/tmp'] to the xhprof.file_storage service definition in xhprof.services.yml .

    I doubt these are appropriate changes for everyone, but perhaps a patch could be made to accommodate those in my position too? Unless it's literally only me! :-D

Production build 0.71.5 2024