Multilingual node tests should use the API rather than form submissions in setUp()

// Enable URL language detection and selection. $edit = ['language_interface[enabled][language-url]' => '1']; $this->drupalPostForm('admin/config/regional/language/detection', $edit, t('Save settings')); // Set "Basic page" content type to use multilingual support. $edit = [ 'language_configuration[language_alterable]' => TRUE, ]; $this->drupalPostForm('admin/structure/types/manage/page', $edit, t('Save content type')); $this->assertRaw(t('The content type %type has been updated.', ['%type' => 'Basic page']), 'Basic page content type has been updated.');

$config = $this->config('language.negotiation'); $config->set('url.prefixes', [ 'en' => 'en', 'de' => 'de', ])->save(); $this->container->get('entity_type.manager')->getStorage('language_content_settings')->create([ 'target_entity_type_id' => $entity_type, 'target_bundle' => $bundle, ])->save();

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
First commit to issue fork.
Merge request !11558Issue #3161684: Use API instead of http requests to setup language negotiation → (Open) created by acbramley
Comment 13 days ago →
🇦🇺Australia acbramley
This was a little tricky to figure out, I had to manually do the steps in a browser and export config before/after to figure out what needed to change (IS was inaccurate)
Pipeline finished with Success
13 days ago
Total: 1005s
#453630
Comment 12 days ago →
🇺🇸United States smustgrave
Are we limiting to just that 1 file? Could that be marked in the summary.

Checking that 1 file could we do more replacements with the drupalCreateNode?
Comment 9 days ago →
🇦🇺Australia acbramley
Rescoping to just NodeFieldMultilingualTest, other tests can be separate issues (e.g 📌 NodeTranslationUITest should use API to set up language Active )

We shouldn't replace the node form submissions because the test is literally testing language functionality of the node form :)
Comment 8 days ago →
🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This looks great and it makes this test a bit faster.

Multilingual node tests should use the API rather than form submissions in setUp()

Problem/Motivation

Proposed resolution

Merge Requests

!11558Multilingual node tests should use the API rather than form submissions in setUp()
Open

Comments & Activities

Multilingual node tests should use the API rather than form submissions in setUp()

Problem/Motivation

Proposed resolution

Merge Requests

!11558Multilingual node tests should use the API rather than form submissions in setUp()Open

Comments & Activities

!11558Multilingual node tests should use the API rather than form submissions in setUp()
Open