Remove the StringTranslationTrait from InstallerException

Created on 23 July 2020, about 4 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

Discovered at #2459671: [PP-1] Add detail to AlreadyInstalledException β†’ -- that issue is trying to extend the installer's AlreadyInstalledException to provide more context for specific scenarios.

However, the current patch β†’ has some crufty doo doo trying to deal with the string_translation service.

Yet due to πŸ› Remove translation of exception messages Fixed we never want to translate anything in exception messages, anyway. Why jump through hoops for dead code?

Proposed resolution

  • Remove the StringTranslationTrait from InstallerException
  • Deprecate the constructor args (in a BC way) and trigger an error if that service is passed to the base class or any children exceptions.

Remaining tasks

  1. Implement proposed resolution.
  2. Reviews / refinements.
  3. RTBC.
  4. Commit.
  5. Unblock #2459671: [PP-1] Add detail to AlreadyInstalledException β†’

User interface changes

N/A

API changes

Deprecate the TranslationInterface argument to InstallederException::__construct() and child classes like AlreadyInstalledException

Data model changes

N/A

Release notes snippet

N/A

πŸ“Œ Task
Status

Needs work

Version

10.1 ✨

Component
InstallΒ  β†’

Last updated 2 days ago

No maintainer
Created by

πŸ‡ΊπŸ‡ΈUnited States dww

Live updates comments and jobs are added and updated live.
  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.71.5 2024