- ๐ณ๐ฑNetherlands MegaChriz
GuzzleHttp decided to deprecate the
getConfig()
and it looks there is no easy replacement for it: https://github.com/guzzle/guzzle/issues/3114
That means I either have to remove this feature, find another way to implement it or ignore the deprecation warning for now. Ignoring it could mean that at some point in the future this feature might stop working.Since no test coverage for this was added, it will be harder to try to find a replacement for this. Also because in #16 I said I wasn't able to reproduce the bug.
@dmundra, @andypost
Can you help with this? - Merge request !182Revert "Issue #3159688 by dmundra, andypost, irinaz, MegaChriz: Send the... โ (Closed) created by MegaChriz
- Status changed to Active
about 2 months ago 12:01pm 12 July 2024 - ๐ณ๐ฑNetherlands MegaChriz
MR 182 is merged manually.
Since this issue is now no longer fixed, I reopen it.
@dmundra said the following about this issue in Slack:
Thanks for working on this. I havenโt revisited that issue and I havenโt run into a case where I have used that module against a service that blocks empty user agents so I am not the best person to look into it right now. I will see if can follow up on the discussions in slack and in the thread but it going to be a while.
Reverting the changes make sense
See also https://drupal.slack.com/archives/C033S2JUMLJ/p1720346469627799
- Status changed to Closed: cannot reproduce
about 2 months ago 10:42pm 19 July 2024 - ๐บ๐ธUnited States dmundra Eugene, OR
So I think this is no longer an issue and so no fix is needed. I tested with a new Drupal site and the latests feeds branch and the requests working to even the site I had an issue with. So I think this should be closed.