MasqueradeBlock & getRedirectResponse improvements

Created on 10 July 2020, over 4 years ago
Updated 19 January 2023, almost 2 years ago

Problem/Motivation
a) When clicking masquerade in the block, the block will often redirect me to the front page. Which it shouldn't. It should allow me to stay on the current page even if the masqueraded user has no permission to see whats on the current page. It's very uncomfortable to always switch back.

b) Also when I'm masqueraded as a user that has no access to the admin toolbar I can't unmasquerade. Therefore I have to logoff and login again.

Proposed resolution
a) Check whether the referer in the header is set, if so redirect me to it. If not only then redirect me to the front page.

b) If I'm currently masqueraded use the MasqueradeBlock to show a unmasquerade button.

Remaining tasks
Review patches.
a) 3158235-get-redirect-response-improvements.patch
b) 3158235-masquerade-block-improvements.patch

User interface changes
Add a unmasquerade button.

Feature request
Status

Needs work

Version

2.0

Component

Code

Created by

🇩🇪Germany eugen zerr

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.71.5 2024