- πΊπΈUnited States smustgrave
With there being an effort to get off jquery where possible now, is there a non jquery solution.
- π¬π§United Kingdom aaron.ferris
smustgrave β credited aaron.ferris β .
- πΊπΈUnited States smustgrave
Closed π Implement countdown counter Needs work as duplicate
- πΊπΈUnited States smustgrave
Rebased for 7.0.x and fixed up some old and removed some crust.
Will still need a post update hook to add the new config setting
Also during testing noticed that when the time ends the page infinitely refreshes unable to submit as the question has no answer.
- π¬π§United Kingdom aaron.ferris
Updated the MR with an update hook to set
timer_format
- Issue was unassigned.
- πΊπΈUnited States smustgrave
Thanks! Now just need to figure out what's going on with that infinite refresh
- π¬π§United Kingdom aaron.ferris
Can confirm this behaviour, I can see the new JS fires the hidden 'finish' button, but each question type will fail validation.
Pushed a change that will resolve that although im not convinced it's the best way to do so, ive added a new triggering element the timer end JS can use that will limit validation fail.
- Status changed to Needs review
3 months ago 5:11pm 8 August 2024 - Status changed to Needs work
3 months ago 8:37am 9 August 2024 - π¬π§United Kingdom aaron.ferris
Setting back to needs work, limit_validation_errors needs an array of elements rather than a boolean.
- Status changed to Needs review
3 months ago 8:42am 9 August 2024 -
smustgrave β
committed 2feaf570 on 7.0.x
Resolve #3157376 "Countdown js"
-
smustgrave β
committed 2feaf570 on 7.0.x
- Status changed to Fixed
3 months ago 5:47pm 9 August 2024 - πΊπΈUnited States smustgrave
Nice find @aaron.ferris.
I'm sure more issues will come out of this but initial testing appears to be working so going to merge.
Thanks everyone!
Automatically closed - issue fixed for 2 weeks with no activity.