Remove uniqid field from serial storage table

Open on Drupal.org →

Created on 18 June 2020, almost 5 years ago

Updated 1 March 2024, about 1 year ago

Problem/Motivation

Currently for each Serial field instance we have a separate table for generating numbers. Each table has the following fields:

sid: PK INT
uniqid: UNI VARCHAR

When we need to generate new number we just insert new record into this table. The last_insert_id() gives us new number. The big question is: why do we have uniqid field? It's not used anywhere, so it's useless. But it can cause problems. It has UNIQUE constraint (which means the value cannot be repeated). And we use uniqid() PHP function to generate the value for that field. As described in documentation this function does not guarantee that the value will be unique. I know that in real life the collisions are almost impossible. But this is "almost impossible", but not "completely impossible". And since it's not used anywhere, I think that field must not exist.

Proposed resolution

Remove uniqid field from the serial storage tables and update INSERT statement to insert row without values.

Remaining tasks

Review, other opinion needed.

User interface changes

None.

API changes

None.

Data model changes

The uniqid field will be removed from serial storage table.

📌 Task

Status

Version

2.0

Component

Code

Created by

🇺🇦Ukraine mpolishchuck

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Merge Requests

!13Remove uniqid field from serial storage table
Open
🇺🇸United States benjifisher
updated 2 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →
🇺🇸United States benjifisher Boston area
The 8.x-1.x branch of this project is no longer maintained, so I am moving this issue to the 2.0.x branch.

I want to think about this issue for a bit, but I will at least create a MR from the patch in #2 so that we can run automated tests on it.
Comment 2 months ago →
🇺🇸United States mlncn Minneapolis, MN, USA
I am getting the behavior described in this comment 🐛 No serials generated for existing content nor for new, silently failing Active with this patch, but my results in testing this module have been so all over the place i don't know if that really knocks this out of RTBC.
Merge request !13Resolve #3152940 "Remove uniqid field" → (Open) created by benjifisher
Comment 2 months ago →
🇺🇸United States benjifisher Boston area
It looks as though I created the issue fork, but forgot to create the MR, when I made Comment #5. I just did that, and rebased the feature branch on the latest 2.0.x.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024