- First commit to issue fork.
- Status changed to Needs review
11 months ago 8:38am 29 January 2024 - last update
11 months ago 29 pass - 🇮🇳India viren18febS
I have added getPluralLabel() in this patch please review.
- 🇬🇧United Kingdom joachim
Looks good.
Just a nitpick: can the call to getSingularLabel(() now be inlined into the array, or is that variable used elsewhere?
- last update
11 months ago 29 pass - 🇮🇳India viren18febS
I have added the getSingularLabel() direct in array , as this variable is not used anywhere , please review.
thanks - Status changed to RTBC
11 months ago 10:35am 29 January 2024 - Status changed to Needs work
11 months ago 8:50pm 31 January 2024 - 🇺🇸United States dww
+ 'plural' => $this->t('@entity_type entities', ['@entity_type' => $this->entityType->getPluralLabel()]),
I thought the point was to remove 'entities' from this.
Don't we just want this?
+ 'singular' => $this->entityType->getSingularLabel(), + 'plural' => $this->entityType->getPluralLabel(),
??
- 🇺🇸United States dww
p.s. But at that point, why do we need this method at all? Oh, I see that's what 📌 Deprecate InlineFormInterface::getEntityTypeLabels() Needs review is about. Maybe we should proceed there, instead?
- 🇺🇸United States dcam
Yes, I apologize for not updating this issue with that information.
- 🇺🇸United States dcam
For the record, my recommendation in 📌 Deprecate InlineFormInterface::getEntityTypeLabels() Needs review is to close this one. Credit should be granted to everyone who contributed here in the other issue.
- 🇺🇸United States dcam
Oh hey, that's right - I have the power to grant credit now. Neat. Just let me know if the plan sounds good.
- 🇺🇸United States dww
For me, I think the scopes make more sense if we just fix this problem here as a stand-alone thing, then deprecate the method entirely in the other issue. There's no particular reason that we should change the text at the same time as deprecating.
So, for me, I'd probably just commit this pretty much as-is and credit the folks here, then we can do a "clean" deprecation in the other issue.
YMMV. /shrug 😂
- Status changed to Needs review
11 months ago 9:33pm 31 January 2024 - 🇺🇸United States dww
E.g. just this. Interdiff is confused, but it's such a small patch, it should be obvious.
- last update
11 months ago 29 pass - 🇺🇸United States dww
Note: although this is technically a "string change" from the perspective of translators, it's actually a win for them/us: removing a
t()
always helps. 😅 So I'm in favor of backporting this to the 3.0.x branch as a fix before 3.0.0 stable, even though that's already in "RC" and therefore we should be well past the point of changingt()
. - Status changed to RTBC
11 months ago 12:15am 1 February 2024 - 🇺🇸United States dcam
That's fine by me. This looks good. It's a simple change to using a well-defined API.
- Status changed to Fixed
11 months ago 1:05am 1 February 2024 - 🇺🇸United States dww
There is no 3.0.x branch yet to backport this to, so this is now done. Thanks, everyone!
Automatically closed - issue fixed for 2 weeks with no activity.