stats/project_analysis job should not produce changes with ONLY FQCN replacements

Created on 3 June 2020, almost 5 years ago
Updated 10 July 2023, almost 2 years ago

Problem/Motivation

A setting in rector.yml auto_import_names: true is used so that when Rector add classes it uses use statements. This setting also changes any use of Fully Qualified Class Name instead of use statement in existing code.

While that is good change it is not deprecation so it produces bigger patches and also patches where this is the only change without remove deprecations.

Proposed resolution

Add to \InfoUpdater\GitHelper::restoreNonRectorChanges() the ability to restore files with only this change. Ideally we remove all these changes even if they happened within files that had deprecation changes but that would require restore individual lines and not files.

Restore the files would mean we would not produce patches with *no* deprecation changes.

Remaining tasks

Do it

๐Ÿ› Bug report
Status

Fixed

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024