Fix \InfoUpdater\GitHelper::restoreNonRectorChanges() to catch lines with close brackets

Created on 1 June 2020, almost 5 years ago
Updated 10 July 2023, over 1 year ago

Problem/Motivation

\InfoUpdater\GitHelper::restoreNonRectorChanges() attempts to restore files that only have whitespace changes. Rector has(had?) a bug where it would make some changes that weren't in any rector rules.

This led to some files that had just whitespace or empty doc block changes. It was working but doesn't take into account lines that just have } and whitespace changes.

Proposed resolution

Fix the regex pattern and add test.

Remaining tasks

๐Ÿ› Bug report
Status

Fixed

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024