- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 1:43pm 18 August 2023 - 🇳🇱Netherlands llewellyn.dawson
Tested the patch and did not work as intended.
Returns no term fields.
- 🇳🇱Netherlands EstherTempel
I tested both #11 patch and #13 patch on a Drupal 10.2 clean installation with webforms version 6.2.
What I noticed is that if you choose webform_entity_checkboxes, webform_entity_select and/or webform_entity_radios (this last one is added in patch #13) the label of the terms are correctly displayed.However if you choose webform_term_select the values are empty, nothing is displayed.
And if you choose for instance webform_term_checkboxes (this element is not added in the patches) the ID is displayed instead of the label.What I notices while debugging is that webform_term_select skips this part of the code:
if (isset($value) && !empty($value)) { if (isset($this->getElements()[$component]['#target_type'])) { $target_type = $this->getElements()[$component]['#target_type']; $entity_storage = \Drupal::entityTypeManager()->getStorage($target_type); $entity = $entity_storage->load($value); if (is_object($entity)) { $value_label = $entity->label(); } } }
- Status changed to Needs review
7 months ago 8:40pm 10 May 2024 - 🇳🇱Netherlands batigolix Utrecht
Here is a new patch that also adds labels for Term select and Term checkbox elements.
- 🇳🇱Netherlands batigolix Utrecht
Here is a new patch rerolled after the PHPCS fixes
- Status changed to RTBC
3 months ago 12:58pm 4 September 2024 - 38fe7368 committed on 8.x-1.x
Issue #3137260 by sokru, batigolix, mohit_aghera, nevergone,...
- 38fe7368 committed on 8.x-1.x
Automatically closed - issue fixed for 2 weeks with no activity.