Using "Automatically submit selection" to select content in a view
Selected lines in the view
Furthermore the view is not submitted, at least in modal, when clicking a line. (I'm not sure if this is intended).
In entity_browser.view.js these are the lines handling these problems:
// If "auto_select" functionality is enabled, then selection column is
// hidden and click on row will actually add element into selection
// display over javascript event. Currently only multistep display
// supports that functionality.
if (drupalSettings.entity_browser_widget.auto_select) {
var selection_cells = views_instance.$view.find('.views-field-entity-browser-select');
// Register on cell parents (rows) click event.
selection_cells.parent()
.once('register-row-click')
.click(function (event) {
event.preventDefault();
var $row = $(this);
// Ensure the use of the entity browser input.
var $input = $row.find('.views-field-entity-browser-select input.form-checkbox, .views-field-entity-browser-select input.form-radio');
// Get selection display element and trigger adding of entity
// over ajax request.
$row.parents('form')
.find('.entities-list')
.trigger('add-entities', [[$input.val()]]);
});
// Hide selection cells (selection column) with checkboxes.
selection_cells.hide();
}
My suggestions is to
event.preventDefault(); to actually mark the checkboxes / radiosAdditionally I think we should use the chance to select the checkbox / radio if clicking the line even with "Automatically submit selection" disabled... This way the line should behave like a label and not require the user to exactly hit the form element representing a line. There is already a similar issue for that point which goes one step further with double click: #2959832: Double click on a row should add to selection and submit →
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Let's start with adding a clearer description: 📌 Add a clear description for the Views widget selector plugin option "Automatically submit selection" Active
Did some initial work here, anyone feel free to move forward!
Postponed on ✨ Check radio / checkbox when checking a line also without auto_submit Active
Once that is fixed, let's add row classes etc.