Domain Access field: machine name should match machine name declared on Domain Access module

Created on 20 April 2020, about 4 years ago
Updated 21 July 2023, 11 months ago

Problem/Motivation

The machine name of the "Domain Access" field is different from the one defined in Domain Access module. So, this forces to check out for different field names depending on which module enabled the domain access on a given entity. This can affect other modules and the views integration.

Proposed resolution

Modify the "Domain Access" field machine name to match Domain Access module field name. In this module, the field name is declared at domain_access.module at line 19.

Once this is fixed, this other issue should be fixed too to avoid domain field deletion on Node and User entities:
πŸ› Node and User entities should be ignored by the UI Active

Remaining tasks

Think about an upgrade path after the field name change. Another option could be to create another branch and maintain both. It would be easy because only the const variable with field name will be different.

πŸ› Bug report
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ͺπŸ‡ΈSpain rcodina

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024