- π§πͺBelgium gilmar.lima Brussels
gilmar.lima β made their first commit to this issueβs fork.
- Status changed to Needs review
over 1 year ago 6:09pm 28 February 2023 - π§πͺBelgium gilmar.lima Brussels
I've created a patch for the issue mentioned. We have also encountered the same issue and it is related to the getLatestRevision function in the AdminModeratedContent class, where the query to retrieve the latest revision has the storage type hardcoded for Nodes.
- @gilmarlima opened merge request.
-
joseph.olstad β
committed cedd1f04 on 3.0.x authored by
gilmar.lima β
Issue #3128412 by gilmar.lima, ericjgruber, Eva.Young: Make this work...
-
joseph.olstad β
committed cedd1f04 on 3.0.x authored by
gilmar.lima β
- Status changed to Needs work
over 1 year ago 6:38pm 1 March 2023 - π¨π¦Canada joseph.olstad
Ok I've pushed that into the 3.0.x branch
Please re-roll for the 2.0.x branch
- Status changed to Needs review
over 1 year ago 6:55pm 1 March 2023 - Assigned to joseph.olstad
- Status changed to Active
over 1 year ago 8:17pm 1 March 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:27pm 1 March 2023 - Status changed to RTBC
over 1 year ago 8:02pm 27 April 2023 - π¨π¦Canada jamesyao
Thanks @joseph.olstad. The patch #20 looks good to me. It works on Drupal Core 9.4.11 & PHP 8.0.
-
joseph.olstad β
committed b86a5915 on 2.0.x authored by
gilmar.lima β
Issue #3128412 by joseph.olstad, gilmar.lima, ericjgruber, Eva.Young,...
-
joseph.olstad β
committed b86a5915 on 2.0.x authored by
gilmar.lima β
- Status changed to Fixed
over 1 year ago 5:32am 28 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 10:16pm 15 June 2023 - πΊπΈUnited States nsciacca
I think this should be re-opened, I tried with the latest version and found the following issues:
1. The actions don't exist for the Bulk Form for media. I manually copied the "system.action.publish_latest" and "system.action.unpublish_latest" to media specific ones to get this to work from within my config sync. However, there should be examples in the module's config/optional folder.
2. Both action plugins for "PublishLatestRevisionAction" and "UnpublishCurrentRevisionAction" had checks in the access function for whether the entity was a node, therefore it would return an Access Denied when applying the action. I updated this to check for either nodes or media.
3. There should be similar settings for the module for "Enable dialog on media edit form" and "Enable dialog on admin media listing". This affects the dialog pop ups and the code is all hard coded to look for node forms.
I have attached a patch for 1 & 2 which at least makes the module functional for media entities. #3 is a larger lift I don't have time for at the moment.
- @nsciacca opened merge request.
- Status changed to Needs review
over 1 year ago 11:15pm 15 June 2023 - π¨π¦Canada joseph.olstad
Hi there, normally we'd create a new issue however since you've already pushed something I'll re-open this one. What is this change about?
-
joseph.olstad β
committed 00cb59cc on 2.0.x authored by
nsciacca β
Issue #3128412: Make this work with Media entities
-
joseph.olstad β
committed 00cb59cc on 2.0.x authored by
nsciacca β
- Status changed to Fixed
over 1 year ago 11:18pm 15 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- π¨π¦Canada joseph.olstad
New support request is opened.
Perhaps some improved documentation on setting this up is needed.
- Status changed to Needs review
8 months ago 3:35am 2 April 2024 - Status changed to Fixed
6 months ago 10:51am 27 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.