Review t() usage for accuracy

Comment over 1 year ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Assigning to myself as I'm triaging all RTBC issues.
Issue was unassigned.
Status changed to Fixed over 1 year ago9:11pm 8 August 2023

🇺🇸United States Kristen Pol Santa Cruz, CA, USA

Repurposing this issue as the patch no longer applies as the code has changed so much. I've reviewed the codebase for usage of t() and things look okay as far as I can tell (see below). If someone sees something amiss, reopen this issue and ideally provide a patch.

I'm crediting everyone who worked on this issue even though the patch is not getting committed as there was valid work done.

@nejcramsak and @Andrii Kleba In the future, please explain more about what you did. Did you test the module? Did you just review the code? Did you do both? If you tested the module, how did you test it? It's important to understand what was done so we are confident it was sufficient. Also, many maintainers won't give issue credit for moving to RTBC without proper information. Thanks.

* [ok] redirect.drush.inc
  * [ok] drush_redirect_generate_redirects
    * return drush_set_error('DEVEL_GENERATE_INVALID_INPUT', t('Invalid number of redirects.'));

* [ok] redirect.generate.inc
  * [ok] redirect_generate_form
    * '#title' => t('How many URL redirects would you like to generate?'), [and more]
  * [ok] redirect_generate_batch_delete
    * $context['message'] = t('Deleted URL redirect @rid.', ['@rid' => end($rids)]);

* [ok] redirect.module
    * [ok] redirect_help
      * $output = '<h3>' . t('About') . '</h3>'; [and more]
    * [ok] redirect_page_build
      * 'title' => t('Add URL redirect from this page to another location'),
    * [ok] redirect_status_code_options
      * 300 => t('300 Multiple Choices'), [and more]
    * [ok] locale_form_redirect_edit_form_alter
      * '#title' => t('Language'), [and more]
    * [ok] redirect_entity_extra_field_info
      * 'label' => t('URL redirects'), [and more]
    * [ok] redirect_form_node_form_alter
      * ['class' => ['redirect-table__path'], 'data' => t('From')], [and more]

* [ok] modules/redirect_404/redirect_404.views.inc
   * [ok] redirect_404_views_data
      * $data['redirect_404']['table']['group'] = t('Redirect 404'); [and more]

* [ok] modules/redirect_404/redirect_404.module
   * [ok] redirect_404_form_redirect_settings_form_alter
      * '#options' => [0 => t('All')] + array_combine($row_limits, $row_limits), [and more]

* [ok] modules/redirect_domain/redirect_domain.module
   * [ok] redirect_domain_help
     * $output = '<h3>' . t('About') . '</h3>'; [and more]

Comment over 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Review t() usage for accuracy

Comments & Activities