- First commit to issue fork.
- @crmn opened merge request.
- Status changed to RTBC
over 1 year ago 10:57am 10 May 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I tested this out, this actually also fixes Acquia Site Studio compatibility!
-
Kingdutch →
committed eca2a887 on 8.x-2.x
Issue #3122871 by crmn, Ruuds, BramDriesen: Analyze frontend theme and...
-
Kingdutch →
committed eca2a887 on 8.x-2.x
-
Kingdutch →
committed 5d876b09 on 8.x-2.x
Issue #3122871 by crmn, Ruuds, BramDriesen, sqf: issue with missing <p>...
-
Kingdutch →
committed 5d876b09 on 8.x-2.x
- Status changed to Fixed
over 1 year ago 3:08pm 16 June 2023 - 🇳🇱Netherlands kingdutch
Rather than using a global setting I've implemented this using configuration on the analysis widget. This allows different types of analysable entities to use different themes if that's desired. I've also used the opportunity to add support for view mode configuration which was a TODO that was in the code and could use the same plumbing. To top it off I've added some test coverage with Behat to confirm everything works (and keeps working) :D
I was able to copy the changes to the analyser as provided, with the adjusted plumbing for the settings.
Thanks for your help! :D This is released as 8.x-2.0-alpha9
Automatically closed - issue fixed for 2 weeks with no activity.