- 🇺🇸United States dww
Now that 📌 Deprecate/remove the ability to update a module from a URL and authorize.php Active and child issues are done, all this code is deprecated and will be removed in D12.
Follow-up to address #3113992-79: The 'Update' page has no idea that some updates are incompatible → (point 3).
In that issue, we're adding a private helper method, UpdateManagerUpdateForm::removeCheckboxFromRow()
That was a compromise to avoid some code duplication and make things easier to read, while trying not to explode the scope of that critical bugfix for a wider refactoring. However, as we now have 3 possible tables on that form, and only one of them needs checkboxes, we should refactor how this all works.
Instead of building up $entry as if it needs a checkbox from the start, the buildForm() method should use a more simple data structure as the bulk of that method runs to store the stuff we always care about (project name, currently installed version, recommended update, etc). Then, once we know what table the entry belongs in, we should have a helper method that converts it into a row that's appropriate for either '#theme' => 'table' or 'tableselect' as appropriate.
📌 Make the table of incompatible releases in UpdateManagerUpdateForm more theme-friendly Closed: outdated is related to this, since that issue might introduce an entirely different twig template for the 'Not compatible' table, so the helper method might need to do something different to generate rows for that table, too.
None.
Nothing public. Only changes to private or protected methods..
None.
N/A.
Closed: won't fix
11.0 🔥
update.module
Enhances developer experience.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Now that 📌 Deprecate/remove the ability to update a module from a URL and authorize.php Active and child issues are done, all this code is deprecated and will be removed in D12.