- 🇮🇳India jaydev bhatt Pune, Maharashtra
Updated the messenger service as a part of the Drupal 10 compatibility Updates check here for more information ( https://www.drupal.org/project/hti/issues/3404526 📌 Drupal 10 compatibility Active ).
as this is no longer needed closing this issues.
marking this as fixed. - 🇮🇳India jaydev bhatt Pune, Maharashtra
i have fixed this issues with the new release for this module.
attaching a screenshot for the same.
making this issues as fixed and closing this issue.Thanks.
- 🇺🇸United States tr Cascadia
No, it's not fixed.
What you committed in 📌 Drupal 10 compatibility Active has the exact same problem I called out more than 4 years ago in #4, in #7, and in #10 above. Your commit was wrong.
I also suggest you read the guidelines for granting credit → . This issue had a working patch developed by the community YEARS before that other issue was even opened. You didn't give credit to anyone here, or anyone in that other issue either, just yourself.
- @jaydev-bhatt opened merge request.
- 🇮🇳India jaydev bhatt Pune, Maharashtra
Thank you for your feedback, @tr. You're absolutely right, and I sincerely apologize for the oversight.
I've committed a fix that properly addresses the issues you pointed out Here. I've removed the unnecessary messenger service injection and corrected the syntax to use$this->messenger()->addMessage()
as you suggested in comments #4, #7, and #10.
I want to express my gratitude to all community members who contributed to this issue, especially:@tr for providing the clear technical guidance on the correct implementation
@Pooja Ganjage for creating the initial patches
@Suresh Prabhu Parkala for the updated patchI should have properly attributed credit in my previous work and followed the community patch that was available years before the Drupal 10 compatibility issue was opened. Thank you for holding me accountable to our community standards.
The fix is now properly implemented. I appreciate your persistence in ensuring the code quality of this module.Keeping this in review. for further verifications.