Coding standard issues

Created on 17 February 2020, over 4 years ago
Updated 9 February 2023, over 1 year ago

While running CodeSniffer I found some coding standard issue. I'll post a patch that will fix them.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to RTBC over 1 year ago
  • πŸ‡΅πŸ‡±Poland sandboxpl Poland πŸ‡΅πŸ‡±

    from recent drupalci output:

    08:54:39 cd modules/contrib/disable_language && sudo -u www-data /var/www/html/vendor/bin/phpcs -e  --report-full=/var/lib/drupalci/workdir/phpcs/codesniffer_results.txt --report-checkstyle=/var/lib/drupalci/workdir/phpcs/checkstyle.xml --report-diff=/var/lib/drupalci/workdir/phpcs/codesniffer_fixes.patch --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md --file-list=/var/lib/drupalci/workdir/phpcs/sniffable_files.txt > /var/lib/drupalci/workdir/phpcs/phpcs_sniffs.txt
    08:54:39 Adjusting paths in report file: /var/lib/drupalci/workspace/jenkins-drupal8_contrib_patches-143065/ancillary/phpcs/checkstyle.xml
    08:54:39 sudo chmod 666 /var/lib/drupalci/workspace/jenkins-drupal8_contrib_patches-143065/ancillary/phpcs/checkstyle.xml
    08:54:39 ---------------- Finished phpcs in 0.745 seconds ---------------- 
    08:54:39 ---------------- Finished validate_codebase in 0.858 seconds ---------------- 
    

    as patch does not provide any logic / data model changes in code, this one is good to go

  • Status changed to Fixed over 1 year ago
  • πŸ‡΅πŸ‡±Poland sandboxpl Poland πŸ‡΅πŸ‡±

    Committed and pushed, thx every1!

  • πŸ‡§πŸ‡ͺBelgium BramDriesen Belgium πŸ‡§πŸ‡ͺ

    Cross referencing because the issue I created was fixed here.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024