Contrib.social

Potentially confusing docblock in language-negotiation-configure-form.html.twig

Open on Drupal.org →
Created on 11 February 2020, over 4 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

In #3111729: Stable templates/CSS that differ only in comments or indentation should match core's version → @dww pointed out 

+++ b/core/themes/stable/templates/admin/language-negotiation-configure-form.html.twig
@@ -1,22 +1,23 @@
+ *   - attributes: A list of HTML attributes for the wrapper
Probably out of scope, but this at first seemed like an indentation bug. Then I realized it's because -children is a top-level variable, not a child of -language_types. Wonder about moving -children to the top of the list, above -langugage_types? That'd both be alphabetical, and it'd avoid the possible confusion that -children is really top-level, not a mistakenly not-indented item under -language_types...

and

It is a little weird to have the first thing in the list something that says "Remaining form items..." -- remaining from what? ;)

Proposed resolution

Determine how to best make this more easily understood and implement that change.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Theme  →

Last updated 1 day ago

Created by

🇺🇸United States bnjmnm Ann Arbor, MI

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024