locale_translation queue loop

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I can still reproduce on Drupal 11.1.3 like this:

1. Force translations to be fetched for a project.
   It can be simulated like this: delete the project item in locale.translation_status key/value storage and set the timestamp and last_checked columns to 0 in the locale_file table.
   I think it has to be a large project where the import will need multiple batch runs.
2. Run the locale_cron cron to create items in the locale_translation queue
3. Start running the locale_translation queue but abort when the locale_translation_batch_fetch_import batch is not finished
4. Run drush locale-update.
   This will import the translation and mark it as current but leave your previous unfinished queue item.
5. Run the locale_translation queue again: it now runs forever.

I will try to write tests for this.

I think I closed this by mistake.

I added a test.

There was 1 failure:
1) Drupal\Tests\locale\Kernel\LocaleBatchTest::testBuildProjects
Failed asserting that null matches expected 1.
/builds/issue/drupal-3109284/core/modules/locale/tests/src/Kernel/LocaleBatchTest.php:45
--
1 test triggered 1 PHP warning:
1) /builds/issue/drupal-3109284/core/modules/locale/tests/src/Kernel/LocaleBatchTest.php:45
Undefined array key "finished"
Triggered by:
* Drupal\Tests\locale\Kernel\LocaleBatchTest::testBuildProjects
  /builds/issue/drupal-3109284/core/modules/locale/tests/src/Kernel/LocaleBatchTest.php:28
FAILURES!
Tests: 1, Assertions: 1, Failures: 1, Warnings: 1.
Exiting with EXIT_CODE=1

Shows the test coverage

Reviewing the actual code change and looks inline with how line 224 is being checked.

LGTM

One comment on the MR.

I added a comment as suggested.

Feedback appears to be addressed

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Moving back to RTBC as this was just a line length change.

Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!

catch → closed merge request !11599