Now that
#2145751: Introduce ENTITY_TYPE_list:BUNDLE cache tag and add it to single bundle listing →
is merged in to Drupal core, we have new cache tags. One would think this would allow for more targeted blacklisting with Purge module, however, the functionality in CacheTagsQueuer for blacklisting in a basic strpos() match:
if (strpos($tag, $prefix) !== FALSE) {
$blacklisted = TRUE;
}
This means that if one has blacklisted the node_list cache tag, for example, the node_list:article cache tag will also get blacklisted.
What I'd like to suggest is either glob matches, or even regular expression matches. Not as a replacement, mind you, as I think that would cause problems for existing sites.
For example, perhaps we could detect if the search pattern is wrapped in / to determine if it is a regex. Then, one could have:
/^node_list$/
And then the logic could change to:
// Check if the blacklist pattern is a regular expression and use
// preg_match() instead of strpos() if so.
if (preg_match('@^/.*/$@', $prefix)) {
if (preg_match($prefix, $tag)) {
$blacklisted = TRUE;
}
}
elseif (strpos($tag, $prefix) !== FALSE) {
$blacklisted = TRUE;
}
That would allow folks to have patterns such as:
# Blacklist node_list exactly.
/^node_list$/
# Blacklist articles listings as well.
node_list:article
Or even fancier, do it in one regular expression:
# Blacklist node_list and node_list:article.
/^node_list(:article)?$/
Needs review
3.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Patch doesn't apply to D10 it seems, needs to be rerolled. Any chance this issue can get some love from the maintainers? 4 years old and it's actually super useful.
I'll try to provide a reroll as soon as I have some time.