- πΊπΈUnited States j-barnes
We are still having this same issue with Barrio, it will select the closest fieldset which breaks functionality when using layout builder to add custom blocks that may contain rich text with inserted links. This works fine on 6.0.0-beta4 when the linkit-autocomplete.js only selected the closet form.
- πΊπΈUnited States mark_fullmer Tucson
Thanks for indicating this is an issue in 6.0.x-dev right now, likely due to changes introduced subsequent to 6.0.0-beta4.
Commits to review:
- https://git.drupalcode.org/project/linkit/-/commit/8aafeae4ae8f98b7c4174...
- https://git.drupalcode.org/project/linkit/-/commit/3d6956d62de462c68d915...
- https://git.drupalcode.org/project/linkit/-/commit/4167d74c47f74dd16cd3d... - π¨πSwitzerland pvbergen
Here's are new patches for the current releases (6.0.2 and 6.1.2).
They only remove "fieldset" from the selector, as "tr" is needed for the claro theme.It would be optimal if linkit would set a class on the appropiate element and use the class in the selector. If I find the time I will try to find a solution for that.
- πΊπΈUnited States mark_fullmer Tucson
It would be optimal if linkit would set a class on the appropiate element and use the class in the selector. If I find the time I will try to find a solution for that.
I agree that this would be the preferable full fix.
- π¨πSwitzerland pvbergen
I've looked into this and came up with a theme agnostic solution.
- In LinkitWidget::formElement, I enclose the linkit elements in a container with class "linkit-widget-container"
- In linkit.module::linkit_form_editor_link_dialog_alter, I add the same class to the form for the editor link dialog
This allows us to access all the fields for one link "entry" within the same group in the frontend using the "linkit-widget-container" css class.I tested it successfully on one of our projects, using claro in the backend and bootstrap_barrio in the frontend.
The only downside is that we change the html structure of the field, adding an additional div for the container.See attached patches for necessary code changes. The changes are the same for to both 6.0.x and 6.1.x.
- last update
12 months ago 82 pass, 2 fail - π¨πSwitzerland pvbergen
Here's a patch for 6.1.x, fixing the failing tests (hopefully).
- last update
12 months ago 82 pass, 2 fail - last update
12 months ago 82 pass, 2 fail