Move HTML classes from template_preprocess_image_widget to a template

Created on 8 January 2020, over 4 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

HTML classes should be usually added in templates instead of preprocess functions. Also, Drupal core modules shouldn't include represantional HTML classes.

Proposed resolution

Move the HTML classes from the preprocess function to the template. The classes should be added in a template in Classy / Stable but not in the module.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

10.1

Component
Image module 

Last updated 3 days ago

Created by

🇫🇮Finland lauriii Finland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Production build 0.71.5 2024