Invalid selector in MaximumFileSizeExceededUploadTest

Created on 25 December 2019, over 4 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

The '.messages--error' selector doesn't actually appear, but this is obscured by the fact $this->assertSession()->waitForElement doesn't assert the element actually appears.

Proposed resolution

switch to '[aria-label="Error message"]' and wrap the assertion in $this->assertNotEmpty().

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
File moduleΒ  β†’

Last updated 3 days ago

Created by

πŸ‡ΊπŸ‡ΈUnited States oknate Greater New York City Area

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.69.0 2024