minor typos or compatibility errors

Created on 14 December 2019, over 5 years ago
Updated 14 March 2025, 26 days ago

First off, thank you so much for contributing this code. It works great once the following two errors are addressed:

Problem/Motivation

PHP Fatal error: Declaration of Drupal\migrate_source_ical\Plugin\migrate\source\Ical::count() must be compatible with Drupal\migrate\Plugin\migrate\source\SourcePluginBase::count($refresh = false) in [path-to-drupal]/modules/contrib/migrate_source_ical/src/Plugin/migrate/source/Ical.php on line 158

Error: Class '\Drupal\migrate_source_ical\Plugin\migrate\ICALReader' not found in [path-to-drupal]/modules/contrib/migrate_source_ical/src/Plugin/migrate/source/Ical.php on line 98

Proposed resolution

Change the former function definition to count($refresh = false), and change the capitalization of the latter class to IcalReader to match its filename.

I'll attach my patch momentarily. Thank you again!

๐Ÿ› Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States BenStallings

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024