- First commit to issue fork.
- @gilmord opened merge request.
- Status changed to Needs review
almost 2 years ago 3:11pm 28 January 2023 - πΊπ¦Ukraine gilmord πΊπ¦Ukraine
Hi, I have opened MR with the fix.
I used the patch as the base but did a small naming change, fixed the issue with the checkbox value not being saved and it is capable with the latest dev version.
Here is the patch:
https://git.drupalcode.org/project/rabbit_hole/-/merge_requests/25.patch - πΊπ¦Ukraine Matroskeen πΊπ¦ Ukraine, Lutsk
@gilmord thanks! Can you please change a target branch to
2.0.x
?8.x-1.x
is for bug fixes only. - πΊπ¦Ukraine gilmord πΊπ¦Ukraine
Rebase is required now, I will check it later
- πΊπ¦Ukraine Matroskeen πΊπ¦ Ukraine, Lutsk
New features will go into 2.0.x
- π©πͺGermany Anybody Porta Westfalica
In a first step, this would be helpful to at least see, as admin, that there's a rabbit hole active: β¨ Add message for admins to indicate what action would happen Fixed
- Status changed to Needs work
almost 2 years ago 3:32pm 22 February 2023 - π©πͺGermany Anybody Porta Westfalica
This needs a manual rebase! :)
- πΊπ¦Ukraine gilmord πΊπ¦Ukraine
@Anybody I did not know what branch has to be used as a base, so I used the one the fork created for me.
And it was an outdated branch, and the fresh one has a lot of changes.Instead of rebasing we should consider reworking it, should be faster than rebasing from an outdated version.
- πΊπΈUnited States Greg Boggs Portland Oregon
+1 for getting this patch working with the latest code, rebase, re-edit whatever is easiest :)
- πΊπΈUnited States Greg Boggs Portland Oregon
Since the base branch got switched after the MR was created, and 8x is different than 2x I am super confused how to rebase this. Anyone else better at git foo than me?
- πΊπΈUnited States Greg Boggs Portland Oregon
Ok, this one is non-trivial and it wasn't my git foo. This patch needs to be reworked because the underlying methods are quite a bit different between version 1 and 2.
- last update
over 1 year ago 12 pass, 6 fail - @matroskeen opened merge request.
- last update
over 1 year ago 12 pass, 6 fail - last update
over 1 year ago 12 pass, 6 fail - last update
over 1 year ago 14 pass, 2 fail - last update
over 1 year ago 20 pass - πΊπΈUnited States Greg Boggs Portland Oregon
Here's a patch of the latest MR to make testing easier
- Status changed to RTBC
over 1 year ago 7:38pm 5 July 2023 - last update
over 1 year ago 20 pass - last update
over 1 year ago Patch Failed to Apply - πΊπΈUnited States Greg Boggs Portland Oregon
The merge request works perfectly! Thanks for the contribution. My team is really looking forward to this feature.
- Assigned to Matroskeen
- πΊπ¦Ukraine Matroskeen πΊπ¦ Ukraine, Lutsk
@Greg Boggs thanks for the manual testing. I started from a bit different approach, but after giving it a second thought, I think the original idea of
no_bypass
property is good and will play nicely along with β¨ Add message for admins to indicate what action would happen Fixed .It'll be committed after adding some tests. I'll work on it tomorrow.
- last update
over 1 year ago 21 pass - last update
over 1 year ago 21 pass - last update
over 1 year ago 21 pass - Issue was unassigned.
- πΊπ¦Ukraine Matroskeen πΊπ¦ Ukraine, Lutsk
Editing the issue summary
- last update
over 1 year ago 21 pass -
Matroskeen β
committed 9ffacb46 on 2.0.x
#3099245: Add option to apply rabbit hole behaviors to all users...
-
Matroskeen β
committed 9ffacb46 on 2.0.x
- Status changed to Fixed
over 1 year ago 9:34am 6 July 2023 - πΊπ¦Ukraine Matroskeen πΊπ¦ Ukraine, Lutsk
It should be good to go. The title and description of new checkbox might be improved, so if you have any suggestions - feel free to open a follow-up task. Thanks everyone!
Automatically closed - issue fixed for 2 weeks with no activity.