- π¬π§United Kingdom oily Greater London
@Dhammika I notice that your 2x patches are named 'fixed-quiz-feedback-issue'. That sounds like it relates to a different issue? Can you please confirm that your patches fix this issue?
- Status changed to Needs review
5 months ago 8:07pm 26 August 2024 - Status changed to Needs work
5 months ago 8:11pm 26 August 2024 - πΊπΈUnited States smustgrave
Only see a test file in the MR. Which if itβs covering a new change would expect to fail.
Also appears to have standard issues.
- π¬π§United Kingdom oily Greater London
I have tried applying the patch of @Dhammika but getting errors.
- Status changed to Needs review
5 months ago 10:24pm 26 August 2024 - Status changed to Needs work
5 months ago 10:47pm 26 August 2024 - πΊπΈUnited States smustgrave
The MR should contain the full fix.
It has a test only feature already built in for testing if it fails without the fix.
- Status changed to Needs review
5 months ago 10:57am 2 September 2024 - π¬π§United Kingdom oily Greater London
@smustgrave I have now included a full fix in the MR. I have updated the issue description.
- Status changed to Needs work
4 months ago 8:06pm 6 September 2024 - π¬π§United Kingdom oily Greater London
@smustgrave Because i thought maybe the reason you had not reviewed for a few days was that I had changed the status to 'needs review' and that that perhaps only maintainers should do that. I believe it IS ready for review.
- Status changed to Needs review
4 months ago 11:54pm 6 September 2024 - πΊπΈUnited States smustgrave
Nope you are free to put into review.
Will try and get to sometime next week.
- π¬π§United Kingdom oily Greater London
@smustgrave To make your task a bit easier, you will find one of my last changes was to an apparently random test. It was a test that I found was failing after I completed the task and got my test to pass. I discovered that the 'random' test contained an assertion for a 403 access denied. So I believed that the condition in my event listener (when a certain exception is raised) must be met in this 'random' test, also. So I edited the test to expect not a 403 but a 200 and redirect to quiz/quiz id. That made it pass along with my new test.
-
smustgrave β
committed 541a38ca on 7.0.x authored by
andrew.farquharson β
Resolve #3088468 "Quiz not redirecting"
-
smustgrave β
committed 541a38ca on 7.0.x authored by
andrew.farquharson β
- Status changed to Fixed
4 months ago 3:52pm 11 September 2024 - πΊπΈUnited States smustgrave
Had to fix up the pipeline to have descriptions and used constructor promotion instead so it's all green now.
- π¬π§United Kingdom oily Greater London
Thank you for completing this fix!
Automatically closed - issue fixed for 2 weeks with no activity.