- π¬π§United Kingdom andrew.farquharson
@Dhammika I notice that your 2x patches are named 'fixed-quiz-feedback-issue'. That sounds like it relates to a different issue? Can you please confirm that your patches fix this issue?
- Status changed to Needs review
12 days ago 8:07pm 26 August 2024 - Status changed to Needs work
12 days ago 8:11pm 26 August 2024 - πΊπΈUnited States smustgrave
Only see a test file in the MR. Which if itβs covering a new change would expect to fail.
Also appears to have standard issues.
- π¬π§United Kingdom andrew.farquharson
I have tried applying the patch of @Dhammika but getting errors.
- Status changed to Needs review
12 days ago 10:24pm 26 August 2024 - Status changed to Needs work
12 days ago 10:47pm 26 August 2024 - πΊπΈUnited States smustgrave
The MR should contain the full fix.
It has a test only feature already built in for testing if it fails without the fix.
- Status changed to Needs review
6 days ago 10:57am 2 September 2024 - π¬π§United Kingdom andrew.farquharson
@smustgrave I have now included a full fix in the MR. I have updated the issue description.
- Status changed to Needs work
1 day ago 8:06pm 6 September 2024 - π¬π§United Kingdom andrew.farquharson
@smustgrave Because i thought maybe the reason you had not reviewed for a few days was that I had changed the status to 'needs review' and that that perhaps only maintainers should do that. I believe it IS ready for review.
- Status changed to Needs review
1 day ago 11:54pm 6 September 2024 - πΊπΈUnited States smustgrave
Nope you are free to put into review.
Will try and get to sometime next week.