- Status changed to Fixed
8 months ago 2:53pm 19 October 2023 - 🇦🇺Australia ELC
Using text/plain for CAS v1 responses. text/xml for all the rest returning xml.
Automatically closed - issue fixed for 2 weeks with no activity.
Hi,
I'm using your CAS server module to build a standard PHP CAS client, it's very handy, thanks for the module :-)
While testing the module, I wasn't able to login because the Content-Type header is not set on the Response when returning XML.
In TicketValidationController.php,
All the calls:
return Response::create($response_text, 200);
Should be replaced with:
return Response::create($response_text, 200, ['Content-Type' => 'text/xml']);
This is a small details but very important knowing that a CAS server may return either XML or JSON.
If needed I can submit a pull request.
Thanks!
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Using text/plain for CAS v1 responses. text/xml for all the rest returning xml.
Automatically closed - issue fixed for 2 weeks with no activity.